You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use the 👍 reaction to show support for this feature.
Avoid commenting unless you have relevant information to add; unnecessary comments create noise for subscribers.
Subscribe to receive notifications about status changes and new comments.
Is your feature request related to a problem? Please describe.
The Comments section in Files supports the Smart Picker, insofar that you can insert links with it. But they don't render as cards.
Describe the solution you'd like
We could make the smart picker cards render in the comments. Or, we could render them below the comment.
In both cases, it is with a maximum of 1 link, a bit like social media tend to do it. Talk does render like that, for reference.
I asked AI to build both options so we can compare them in screenshots, but they basically look the same.
The only difference is that the -inline variant gets a scrollbar in the comment field - not really nice.
Describe alternatives you've considered
I guess the main reason not to do it is size - there's not a ton of space, esp in the width in the right sidebar.
I will create 2 PR's - can pick the best approach, or close both...
EDIT: the inline has various issues, with a scrollbar in the comment, besides having less width to play with of course.
Let's go for #63493 as solution... It's much simpler, too.
Tip
Help move this idea forward
Is your feature request related to a problem? Please describe.
The Comments section in Files supports the Smart Picker, insofar that you can insert links with it. But they don't render as cards.
Describe the solution you'd like
We could make the smart picker cards render in the comments. Or, we could render them below the comment.
In both cases, it is with a maximum of 1 link, a bit like social media tend to do it. Talk does render like that, for reference.
I asked AI to build both options so we can compare them in screenshots, but they basically look the same.
The only difference is that the -inline variant gets a scrollbar in the comment field - not really nice.
Describe alternatives you've considered
I guess the main reason not to do it is size - there's not a ton of space, esp in the width in the right sidebar.
I will create 2 PR's - can pick the best approach, or close both...
EDIT: the inline has various issues, with a scrollbar in the comment, besides having less width to play with of course.
Let's go for #63493 as solution... It's much simpler, too.
Additional context