[Common] Improve track selection - #17572
Merged
Merged
Conversation
ktf
commented
Aug 24, 2026
ktf
commented
Member
- Avoid redundant IsRun2 check
- Avoid doing IsSelected() twice
- Use std::pow (float) rather than C pow (double)
* Avoid redundant IsRun2 check * Avoid doing IsSelected() twice * Use std::pow (float) rather than C pow (double)
ktf
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene and
jgrosseo
as code owners
August 24, 2026 08:48
|
O2 linter results: ❌ 2 errors, |
github-actions
Bot
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for 5a1a63e at 2026-08-24 14:22: Full log here. |
Member
Author
|
@dsekihat can you have a look here? It should be safe. |
dsekihat
approved these changes
Aug 25, 2026
Collaborator
|
Dear @ktf , Thank you for the PR. It looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.