Skip to content

[PWGHF] taskFlow.cxx : fix typo in efficiency fetching - #17590

Open
AlexianL wants to merge 11 commits into
AliceO2Group:masterfrom
AlexianL:modify_taskFlow
Open

[PWGHF] taskFlow.cxx : fix typo in efficiency fetching#17590
AlexianL wants to merge 11 commits into
AliceO2Group:masterfrom
AlexianL:modify_taskFlow

Conversation

@AlexianL

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title taskFlow.cxx : fix typo in efficiency fetching [PWGHF] taskFlow.cxx : fix typo in efficiency fetching Aug 25, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 76ad337 at 2026-08-25 15:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 16 errors and 22 warnings.'
Found 16 errors and 22 warnings.
++ [[ 16 -gt 0 ]]
++ cat /sw/BUILD/fc9027c88c860226bff8a80cced9e16037685c55/O2Physics-code-check/errors.txt
PWGHF/HFC/Tasks/taskFlow.cxx:289:59: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:1003:47: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:1295:43: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:1322:23: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:1604:23: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:1737:15: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:1841:23: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:2040:23: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:2301:23: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:2445:23: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:2505:23: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:3232:22: error: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:4172:22: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:4564:24: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:4594:34: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGHF/HFC/Tasks/taskFlow.cxx:4595:34: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 22 -gt 0 ]]
++ cat /sw/BUILD/fc9027c88c860226bff8a80cced9e16037685c55/O2Physics-code-check/warnings.txt
PWGHF/HFC/Tasks/taskFlow.cxx:180:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:181:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:182:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:183:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:184:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:199:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:347:35: warning: initializer for member 'cstFT0RelGain' is redundant [readability-redundant-member-init]
PWGHF/HFC/Tasks/taskFlow.cxx:510:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:522:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:540:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:590:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:600:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGHF/HFC/Tasks/taskFlow.cxx:1223:60: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:1230:60: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:1237:60: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:1244:58: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
PWGHF/HFC/Tasks/taskFlow.cxx:2635:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:2697:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:2761:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:2832:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:2924:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGHF/HFC/Tasks/taskFlow.cxx:4669:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
++ [[ 16 -gt 0 ]]
++ exit 1
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants