Validate ColumnArray element types before appending - #554
Open
fallintoplace wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ColumnArray::AppendAsColumn()changes offsets.LowCardinality,Bool/UInt8, and nested arrays.ColumnDateTimetimezone metadata throughSlice()andCloneEmpty().Why?
Append()can silently ignore an incompatible column.AppendAsColumn()still adds the source size to offsets after that. The array can then report rows that are not present in nested data and the native stream can get out of sync.This checks the type first and throws
ValidationErrorbefore nested data or offsets are changed. The DateTime metadata fix keeps same-type arrays compatible whenAppend()slices their rows.Tests
cmake --build build --target clickhouse-cpp-ut -j 8./build/ut/clickhouse-cpp-ut --gtest_filter='ColumnArray.*:ColumnArrayT.*:ColumnsCase.*:ColumnLowCardinality.*'Related to #543