London | 26-ITP-May | Edina Kurdi | Sprint 3 | Programmer Humour - #555
Open
edinakurdi wants to merge 8 commits into
Open
London | 26-ITP-May | Edina Kurdi | Sprint 3 | Programmer Humour#555edinakurdi wants to merge 8 commits into
edinakurdi wants to merge 8 commits into
Conversation
edinakurdi
added
🏕 Priority Mandatory
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 25, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Great work overall! Just one minor code-quality improvement needed. Thanks
| @@ -0,0 +1,35 @@ | |||
| const endpointAPI = "https://xkcd.now.sh/?comic=latest"; | |||
There was a problem hiding this comment.
endpointAPI is used both outside and inside the function. This can be confusing, so Its best to rename the function parameter to make the code clearer and avoid shadowing.
more on shadowing here:
https://www.geeksforgeeks.org/javascript/variable-shadowing-in-javascript/
hey-hammad
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist