Skip to content

North West | 12-SDC-July | Liam Greenfield | Sprint 1 | Number Systems - #667

Open
Liam310 wants to merge 3 commits into
CodeYourFuture:mainfrom
Liam310:number-systems
Open

North West | 12-SDC-July | Liam Greenfield | Sprint 1 | Number Systems#667
Liam310 wants to merge 3 commits into
CodeYourFuture:mainfrom
Liam310:number-systems

Conversation

@Liam310

@Liam310 Liam310 commented Aug 24, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1146

Changelist

  • Answer all the questions in the number systems exercises regarding conversion between hexademical, binary, and decimal numbers

No conversion technology was used in answering these questions.

@Liam310 Liam310 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
Poonam-raj
Poonam-raj reviewed Aug 24, 2026
View reviewed changes
Comment thread number-systems/Part-2.md Outdated
Poonam-raj
Poonam-raj reviewed Aug 24, 2026
View reviewed changes
Comment thread number-systems/Part-2.md Outdated
Poonam-raj
Poonam-raj reviewed Aug 24, 2026
View reviewed changes

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some good work here - I've left some questions on some incorrect or under-explained answers

@Poonam-raj Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 24, 2026
@Liam310 Liam310 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Results of test:
You passed 15/15 tasks in part 1.
Please let a volunteer check the answers for part 2.
If you want to re-run the automated tests after changing some code, remove the 'Needs Review' label, wait a little, and then re-add the 'Needs Review' label on your PR.

@Poonam-raj Poonam-raj added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 24, 2026
@Poonam-raj

Poonam-raj commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Thank you for the changes 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Poonam-raj Poonam-raj Poonam-raj left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Liam310 @Poonam-raj