Drop Apache Commons and Log4J Over SLF4J dependencies - #56
Merged
Conversation
rnc
reviewed
Aug 24, 2026
|
|
||
| <properties> | ||
| <projectOwner>Red Hat, Inc.</projectOwner> | ||
| <javaVersion>1.8</javaVersion> |
Contributor
There was a problem hiding this comment.
This project seems to be only used by Indy and Kojiji both of which are 11 so this is fine.
rnc
reviewed
Aug 24, 2026
| <groupId>org.commonjava.boms</groupId> | ||
| <artifactId>web-commons-bom</artifactId> | ||
| <version>31</version> | ||
| <version>34</version> |
Contributor
There was a problem hiding this comment.
This is fine but as part of NCL9918 we'll probably need to update the webcommonsbom
Contributor
Author
There was a problem hiding this comment.
This manages: slf4j, logback, junit, and hamcrest versions here.
rnc
approved these changes
Aug 24, 2026
Contributor
|
@dwalluck Needs a rebase after the other PRs were merged. |
Bump Java to 11 and web-commons-bom to 34
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump Java to 11 and web-commons-bom to 34