Resolve Clippy manual-pattern-char-comparison in JSONPath segment parsing - #55
Draft
dogenkigen with Copilot wants to merge 2 commits into
Draft
Resolve Clippy manual-pattern-char-comparison in JSONPath segment parsing#55dogenkigen with Copilot wants to merge 2 commits into
manual-pattern-char-comparison in JSONPath segment parsing#55dogenkigen with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: dogenkigen <2345634+dogenkigen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix linter issue with manual char comparison
Resolve Clippy Mar 6, 2026
manual-pattern-char-comparison in JSONPath segment parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing in the lint stage due to
-D warningsenforcingclippy::manual-pattern-char-comparisonin JSONPath parsing (src/json_diff/path.rs). The parser used a manual closure for delimiter matching where Clippy expects a char-pattern split.Problem summary
.split(|c| c == '.' || c == '[')), causing compilation to fail under strict lint settings.Code change
Scope
Path::from_jsonpathwith no behavioral expansion; parsing semantics remain aligned with existing path tokenization logic.馃敀 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.