Fix sycl::queue leak in usm_ndarray get_queue()/get_device() - #3042
Open
vlad-perevezentsev wants to merge 2 commits into
Open
Fix sycl::queue leak in usm_ndarray get_queue()/get_device()#3042vlad-perevezentsev wants to merge 2 commits into
get_queue()/get_device()#3042vlad-perevezentsev wants to merge 2 commits into
Conversation
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
August 25, 2026 16:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak in the C++ accessors
usm_ndarray::get_queue()andget_device()indpnp/include/dpnp4pybind11.hppUsmNDArray_GetQueueRef_(dpnp'susm_ndarray.get_queue_ref()) returns an owning copy of the queue (it callsDPCTLQueue_Copyi.e. newsycl::queue)Both accessors dereferenced this pointer and copied the queue out but never freed the heap copy, leaking one
sycl::queueper call. Under queue churn this keepsqueue_implalive and prevents reuse of the associated Level Zero command lists / event pools.The fix takes ownership of the returned copy with
std::unique_ptr<sycl::queue>.dpctl needs no change because its
Memory_GetQueueRefreturns a borrowed ref, whereas dpnp'sUsmNDArray_GetQueueRefis documented to return a copy so it must be deleted.