Add ndmax keyword to dpnp.array - #3044
Draft
antonwolfy wants to merge 2 commits into
Draft
Conversation
Align dpnp.array with NumPy 2.4.0, which added an ndmax keyword. The truncating behavior of ndmax produces object-dtype arrays, which USM arrays cannot represent, so ndmax is accepted only with its default value 0 and raises NotImplementedError otherwise.
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3044/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev6=py314ha0e2e8e_18 ran successfully. |
An explicit ndmax=0 makes NumPy cap the result at zero dimensions and raise, so it cannot serve as a test baseline. Compare dpnp's no-op ndmax=0 against NumPy's no-op (ndmax >= ndim) and gate the test on numpy>=2.4, where the ndmax keyword is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.4.0 added a new
ndmaxkeyword tonumpy.array. This PR alignsdpnp.arraywith that signature.