release(local-notifications): 7.0.0 - #673
Open
NathanWalker wants to merge 1 commit into
Open
Conversation
Published to npm as @nativescript/local-notifications@7.0.0. Ships #639, which switched the plugin to @nativescript-community/perms v3 and was merged after 6.4.0 was cut. Major bump because v3's check()/request() resolve to a Status string rather than the v2 [Status, boolean] tuple. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the
@nativescript/local-notifications@7.0.0release, already published to npm.Why this was needed
a503c40 (#639) landed after the 6.4.0 release commit and no release had been cut since, so the published
6.4.0still shipped the old code and@nativescript-community/perms: ^2.3.0. A user reported the commit missing from the latest package — it was.Why major, not patch
perms v3 changed the resolved value of
check()/request():check('notification')[Status, boolean]tupleStatusstringisAuthorizedwas updated to match, so the plugin now requires perms v3. Apps pinning perms v2 must upgrade.Note
nx build local-notificationsdid not pass onmainbefore this — the rootpermsdevDependency was still v2, whereResultis not generic, soindex.android.ts:298failed withTS2315. That is fixed by #679.🤖 Generated with Claude Code