fix(build): reference the iOS LocationEssentials typings - #674
Open
NathanWalker wants to merge 1 commit into
Open
fix(build): reference the iOS LocationEssentials typings#674NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
@nativescript/types-ios v9 moved CLLocation, CLLocationCoordinate2D and CLLocationCoordinate2DMake out of objc!CoreLocation.d.ts into objc!_LocationEssentials.d.ts, which nothing referenced. Without it `nx build geolocation` fails with 8 "Cannot find name 'CLLocation'" errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nx build geolocationcurrently fails onmainwith 8 errors:@nativescript/types-iosv9 movedCLLocation,CLLocationCoordinate2DandCLLocationCoordinate2DMakeout ofobjc!CoreLocation.d.tsand intoobjc!_LocationEssentials.d.ts. The rootreferences.d.tsreferences the former but never picked up the latter, so those symbols resolve nowhere.One line added to
references.d.ts.nx build geolocationis clean afterwards.Independent of the perms v3 work, but worth merging first — it is what makes #675 verifiable.
🤖 Generated with Claude Code