Skip to content

feat(camera)!: migrate to @nativescript-community/perms v3 #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(camera)!: migrate to @nativescript-community/perms v3 #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions packages/camera/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,8 @@ export function getAspectSafeDimensions(sourceWidth, sourceHeight, reqWidth, req
height: Math.floor(sourceHeight / aspectCoef),
};
}
function mapStatus(result: permissions.Result): Status {
let status = Status.unknown;
if (result && result.length > 1) {
if (Object.keys(Status).findIndex((k) => k === result[0]) >= 0) {
status = Status[result[0]];
}
}
return status;
function mapStatus(result: permissions.Status): Status {
return Status[result] ?? Status.unknown;
}
export function mapError(e): PermissionResult {
return {
Expand All @@ -26,7 +20,7 @@ export function mapError(e): PermissionResult {
Error: e,
};
}
export function mapCameraPermissionStatus(permission: permissions.Result): PermissionResult {
export function mapCameraPermissionStatus(permission: permissions.Status): PermissionResult {
const status = mapStatus(permission);
const result = {
Success: status === Status.authorized,
Expand All @@ -35,7 +29,7 @@ export function mapCameraPermissionStatus(permission: permissions.Result): Permi
return result;
}

export function mapPhotoPermissionStatus(permission: permissions.Result): PermissionResult {
export function mapPhotoPermissionStatus(permission: permissions.Status): PermissionResult {
const status = mapStatus(permission);
const result = {
Success: status === Status.authorized || status === Status.limited,
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"readmeFilename": "README.md",
"bootstrapper": "@nativescript/plugin-seed",
"dependencies": {
"@nativescript-community/perms": "^2.3.1"
"@nativescript-community/perms": "^3.0.4"
}
}