wasm: guard remaining KERNEL assignments so KERNEL.$(TARGET_CORE) overrides survive - #5996
Open
MMesch wants to merge 1 commit into
Open
wasm: guard remaining KERNEL assignments so KERNEL.$(TARGET_CORE) overrides survive#5996MMesch wants to merge 1 commit into
MMesch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5993. Base
kernel/wasm/KERNELis included afterKERNEL.$(TARGET_CORE)(kernel/Makefile:119-121), so unguarded=assignments in the base file clobber per-target overrides. #5984 (AXPY), #5983 (GEMM/TRMM), and #5990 (GEMV) fixed this family-by-family; this PR wraps every remaining assignment inifndefso future WASM sub-targets can override any kernel without a matching guard edit here.On
develop, the still-unguarded families this PR moves are SDOT / DDOT / SROT / DROT. SIMD-opcode counts inlibopenblas.sofor these kernels (measured against thev0.3.34tag, since that predates the prior guard PRs):Downstream (emscripten-forge/recipes#6343): 1.5-2x speedup on
numpy.correlateunder Node/Emscripten (TARGET=WASM128_GENERIC,USE_THREAD=0).Tested with
utestand CBLASctestL1/L2/L3 under Node.