Skip to content

Show Forbidden Jewels' Allocated Node in their names - #10279

Open
cupkax wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
cupkax:add-forbidden-jewels-allocated-node-name
Open

Show Forbidden Jewels' Allocated Node in their names#10279
cupkax wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
cupkax:add-forbidden-jewels-allocated-node-name

Conversation

@cupkax

@cupkax cupkax commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

QoL for #10235.

I noticed when ff counterpart jewels are auto-generated, if a user adds a few different sets, it's hard to keep track of which jewels correspond to which set (unless hovered over).

This PR adds the allocated node's name within each jewel's entry in the item tab, while truncating longer ascendancy names such as Champion's First to Strike, Last to Fall. With regards to the original qol issue mentioned earlier, it also makes sure the node names stay in sync on edit.

Before:

image

After:

image
forbidden-jewels-names.mp4

@vaisest

vaisest commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Appending to the title will probably break the buy similar search. It adds the unique title to the search. I don't think the title should be modified since unique code tends to use it for checking what unique it is

@cupkax

cupkax commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Appending to the title will probably break the buy similar search. It adds the unique title to the search. I don't think the title should be modified since unique code tends to use it for checking what unique it is

Ah, gotcha. In that case, I believe it could left as is, or wonder if there's a better qop that could be done here.

EDIT: All good here, name's only for display with no item-title change

@cupkax
cupkax marked this pull request as draft August 24, 2026 05:26
@cupkax
cupkax marked this pull request as ready for review August 24, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants