Show Forbidden Jewels' Allocated Node in their names - #10279
Open
cupkax wants to merge 1 commit into
Open
Conversation
Contributor
|
Appending to the title will probably break the buy similar search. It adds the unique title to the search. I don't think the title should be modified since unique code tends to use it for checking what unique it is |
Contributor
Author
Ah, gotcha. In that case, I believe it could left as is, or wonder if there's a better qop that could be done here. EDIT: All good here, name's only for display with no item-title change |
cupkax
marked this pull request as draft
August 24, 2026 05:26
cupkax
marked this pull request as ready for review
August 24, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
QoL for #10235.
I noticed when ff counterpart jewels are auto-generated, if a user adds a few different sets, it's hard to keep track of which jewels correspond to which set (unless hovered over).
This PR adds the allocated node's name within each jewel's entry in the item tab, while truncating longer ascendancy names such as Champion's
First to Strike, Last to Fall. With regards to the original qol issue mentioned earlier, it also makes sure the node names stay in sync on edit.Before:
After:
forbidden-jewels-names.mp4