Fix defence stats not looking good in breakdown hover - #10281
Conversation
|
The new breakdown appears to duplicate and mislabel item-sourced base modifiers:
The final Armour and Energy Shield totals are still correct; the issue is the explanatory grouping. I did not reproduce the hover interactively; this is based on the PR screenshots and a direct trace of the relevant source path. AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex. |
Fixed in c2abc71. I also added some explanations for how this exactly works since it's probably not the clearest code ever. I also removed the inc from tree section.
|

Fixes #10278.
Description of the problem being solved:
Changes the first calc cell to not use the breakdown which looks worse than the mod lists. This also fixes the hover easily by removing the breakdown override.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
See linked issue
After screenshot: