Skip to content

Fix defence stats not looking good in breakdown hover - #10281

Open
vaisest wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-hover-details
Open

Fix defence stats not looking good in breakdown hover#10281
vaisest wants to merge 4 commits into
PathOfBuildingCommunity:devfrom
vaisest:fix-hover-details

Conversation

@vaisest

@vaisest vaisest commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #10278.

Description of the problem being solved:

Changes the first calc cell to not use the breakdown which looks worse than the mod lists. This also fixes the hover easily by removing the breakdown override.

Steps taken to verify a working solution:

Link to a build that showcases this PR:

See linked issue

After screenshot:

image image image image image

@LocalIdentity LocalIdentity added the technical Hidden from release notes label Aug 24, 2026
@vaisest vaisest added the pob2 Label for features that should be ported over to PoB-PoE2 label Aug 24, 2026
@mcagnion

Copy link
Copy Markdown
Contributor

The new breakdown appears to duplicate and mislabel item-sourced base modifiers:

  • In the Armour screenshot, the calculation table attributes 1,343 base Armour to Aegis Aurora, while “Base from Armours” lists 2,925 from the Granite Flask. The same 2,925 modifier then appears again under “Global Base”.
  • In the Energy Shield screenshot, the intrinsic equipment bases total 2,396, while “Base from Armours” lists 109 from the Seaglass Amulet. The same 109 modifier also appears under “Global Base”.

The final Armour and Energy Shield totals are still correct; the issue is the explanatory grouping. Base from Armours now selects BASE modifiers whose source is Item, while Global Base includes those same modifiers, and the intrinsic armour-property bases remain in the calculation table above. Is that grouping intentional? If not, the modifier-only “Base from Armours” section may need to be removed, renamed, or separated from “Global Base”.

I did not reproduce the hover interactively; this is based on the PR screenshots and a direct trace of the relevant source path.

AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex.

@vaisest

vaisest commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

The new breakdown appears to duplicate and mislabel item-sourced base modifiers:

Fixed in c2abc71. I also added some explanations for how this exactly works since it's probably not the clearest code ever. I also removed the inc from tree section.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pob2 Label for features that should be ported over to PoB-PoE2 technical Hidden from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Energy Shield side bar breakdown not working on Minions

3 participants