Improve Items tab width, filtering, sorting, and item icons - #10292
Draft
AdamZ-8113 wants to merge 3 commits into
Draft
Improve Items tab width, filtering, sorting, and item icons#10292AdamZ-8113 wants to merge 3 commits into
AdamZ-8113 wants to merge 3 commits into
Conversation
Expand the Items tab layout and add non-destructive filtering and sorting views while preserving the custom item order. Keep newly added items visible and selected across each item-add path.
Forward-port the Items tab icon work from PathOfBuildingCommunity#7265 by Simone. Reuse a shared slot icon module across the Skills, Item Database, and All Items lists, with support for loadout group headers. Co-authored-by: Simone <simone@duiker101.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The Items tab's All Items area is cramped and its existing Sort action permanently rewrites the build's item order. It also lacks quick ways to filter and inspect larger item collections, and newly added items can remain hidden by the current view.
This PR:
The icon work forward-ports Simone's work from #7265 (original commit
f6a892a39109a9c591625bf85d35c09913c5004b). The two PNG assets are byte-identical to Simone's originals; the implementation is adapted to the current class/module structure and the new loadout group headers.Steps taken to verify a working solution:
docker compose run --rm --no-deps busted-tests busted --lua=luajit -p TestItemDBControl_spec.lua: 5 successes, 0 failures, 0 errors.docker compose run --rm --no-deps busted-tests busted --lua=luajit -p TestItemListControl_spec.lua: 20 successes, 0 failures, 0 errors.spec/System/TestItemParse_spec.lua:1362.git diff --check upstream/dev..HEADpasses.The complete-suite error comes from
new("Item", raw)in the test added by commitd815ced0dfd17b443ba83ccda0dac812cb4068fb/ #10174. Current class construction requiresnew("Item"):Item(raw). This PR does not modify that test,Modules/Common.lua, orClasses/Item.lua; the unrelated test was intentionally left unchanged to keep this PR scoped.Link to a build that showcases this PR:
Not applicable; this is an Items-tab UI and list-management change.
Before screenshot:
After screenshot: