fix: migrate msg buffer to Calcit 0.13.42 - #31
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the project to Calcit 0.13.40 and Respo 0.16.85.
Changes:
- Upgrades Calcit,
@calcit/procs, and Respo dependencies. - Updates DOM event handlers for typed
Unitreturns. - Adds migration history and refreshed lockfile metadata.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Summary |
|---|---|
yarn.lock |
Locks @calcit/procs 0.13.40 and its checksum. |
package.json |
Updates the @calcit/procs runtime dependency. |
history/20260824-upgrade-calcit-01340.md |
Documents the migration and validation. |
deps.cirru |
Updates Calcit and Respo versions. |
calcit.cirru |
Contains two critical findings: ;nil and (;nil) are comments, not expressions, so several handlers still do not explicitly return Unit. |
Suppressed comments (23)
calcit.cirru:674
(;nil)is a comment form in Calcit, not an expression, so this handler still returns the result of the lastreset!rather than explicitly returningUnit. Replace it with an actualnilexpression for the typed event contract.
:on-click $ fn (e d!) (reset! *archived-sessions false) (reset! *viewing-archive-session false) (;nil)
calcit.cirru:705
(;nil)is a comment form in Calcit, not an expression, so this handler still returns the result ofreset!rather than explicitly returningUnit. Replace it with an actualnilexpression for the typed event contract.
:on-click $ fn (e d!) (reset! *viewing-archive-session session) (;nil)
calcit.cirru:732
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this asynchronous event handler. Add a realnilexpression after the existing effects so the Respo event contract is actually satisfied.
;nil
calcit.cirru:747
(;nil)is a comment form in Calcit, not an expression, so this handler still returns the result of.showrather than explicitly returningUnit. Replace it with an actualnilexpression for the typed event contract.
:on-click $ fn (e d!) (.show sessions-plugin d!) (;nil)
calcit.cirru:812
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after.show/submit-message!so the Respo event contract is actually satisfied.
;nil
calcit.cirru:827
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after the focus/update effects so the Respo event contract is actually satisfied.
;nil
calcit.cirru:854
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after.showso the Respo event contract is actually satisfied.
;nil
calcit.cirru:895
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after the extension message effect so the Respo event contract is actually satisfied.
;nil
calcit.cirru:924
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after the focus effect so the Respo event contract is actually satisfied.
;nil
calcit.cirru:938
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this input handler. Add a realnilexpression after the state update so the Respo event contract is actually satisfied.
;nil
calcit.cirru:947
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this keydown handler. Add a realnilexpression after the conditional submit so the Respo event contract is actually satisfied.
;nil
calcit.cirru:963
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this focus handler. Add a realnilexpression after the class-list effects so the Respo event contract is actually satisfied.
;nil
calcit.cirru:979
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this blur handler. Add a realnilexpression after the class-list effects so the Respo event contract is actually satisfied.
;nil
calcit.cirru:994
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after clearing and focusing the prompt so the Respo event contract is actually satisfied.
;nil
calcit.cirru:1007
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after toggling the think state so the Respo event contract is actually satisfied.
;nil
calcit.cirru:1021
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after toggling the search state so the Respo event contract is actually satisfied.
;nil
calcit.cirru:1033
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this submit handler. Add a realnilexpression afteron-submitso the Respo event contract is actually satisfied.
;nil
calcit.cirru:1062
(;nil)is a comment form in Calcit, not an expression, so this handler still returns the result ofon-view-archiverather than explicitly returningUnit. Replace it with an actualnilexpression for the typed event contract.
:on-click $ fn (e d!) (on-close d!) (on-view-archive d!) (;nil)
calcit.cirru:1089
(;nil)is a comment form in Calcit, not an expression, so this handler still returns the result ofon-closerather than explicitly returningUnit. Replace it with an actualnilexpression for the typed event contract.
:on-click $ fn (e d!) (on-select session-id d!) (on-close d!) (;nil)
calcit.cirru:1109
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this handler. Add a realnilexpression after stopping propagation and dispatching the removal so the Respo event contract is actually satisfied.
;nil
calcit.cirru:1122
(;nil)is a comment form in Calcit, not an expression, so this handler still returns the result oftab-echo!rather than explicitly returningUnit. Replace it with an actualnilexpression for the typed event contract.
:on-click $ fn (e d!) (tab-echo! sessions :edn) (;nil)
calcit.cirru:1124
(;nil)is a comment form in Calcit, not an expression, so this handler still returns the result ofdownload-sessions!rather than explicitly returningUnit. Replace it with an actualnilexpression for the typed event contract.
:on-click $ fn (e d!) (download-sessions! sessions) (;nil)
calcit.cirru:1140
;nilis only a comment in Calcit, so it does not add the promisedUnitreturn to this asynchronous archive handler. Add a realnilexpression after the archive effects so the Respo event contract is actually satisfied.
;nil
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@calcit/procsruntime to Calcit 0.13.42@google/genaito 2.18.0console.error, while retaining the UI failure stateRespo/respo-markdown.calcitto 0.4.25, which unwraps current Calcit Option values before rendering table headers&unitevent-handler results, distinct from applicationnilValidation
calcit calcit.cirru --check-onlywith Calcit 0.13.42yarn vite build --base=./Expected listerror; forced request error is surfaced throughconsole.errorgemini-3.1-flash-liteandgemini-3.7-flashDepends on Calcit 0.13.42 and Respo Markdown 0.4.25.