fix(react): keep the inline math popup unclipped in table cells - #3002
fix(react): keep the inline math popup unclipped in table cells#3002maboukerfa wants to merge 1 commit into
Conversation
|
@maboukerfa is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughInline source previews now use Floating UI for fixed positioning, collision handling, and automatic updates. The preview container provides the anchor, and popup CSS resets its margin and applies a UI-relative z-index. ChangesInline source preview
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change keeps inline source popups visible in table cells without any actionable merge-blocking risk remaining. Sequence Diagram(s)sequenceDiagram
participant SourceWithPreview
participant FloatingUI
participant PreviewPopup
SourceWithPreview->>FloatingUI: Configure inline popup positioning
SourceWithPreview->>FloatingUI: Register preview container anchor
FloatingUI->>PreviewPopup: Apply computed position and styles
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bc9ba32 to
1c5dbb9
Compare
Summary
Editing an inline equation inside a table cell was cut off. The source popup opens below the equation preciew, which in a table cell is outside the table, and the table clips whatever leaves it, so the input and its OK button were partly or entirely invisible.
Changes
fixedstrategy, so no ancestor'soverflowcan clip it.z-indexand would otherwise paint over it.Impact
Before
Screen.Recording.2026-08-23.at.18.12.10.mov
After
Screen.Recording.2026-08-23.at.18.14.21.mov
Testing
Current test pass, and i verified in the browser.
Checklist
Summary by CodeRabbit