fix(ui): give the tag, user and badge pages an h1 - #1590
Closed
culfin wants to merge 1 commit into
Closed
Conversation
Follow-up to apache#1588, which fixed the question list and the two pages that embed it. Three more pages carry their title as `h3` and have no `h1` at all: ui/src/pages/Tags/index.tsx:84 <h3 className="mb-4">{t("title")}</h3> ui/src/pages/Users/index.tsx:46 <h3 className="mb-4">{t("title")}</h3> ui/src/pages/Badges/index.tsx:38 <h3 className="mb-4">{t("title")}</h3> The groups below them jump further than one level — `h6` on the user page, `h5` on the badge page — so they become `h2`, one step under the title. `fs-3`, `fs-6` and `fs-5` carry the sizes the old tags had, so nothing changes on screen. Checked with prettier, eslint and tsc. Still without any heading, and therefore not in this change: the settings pages and search results. Those need wording and an i18n key, which is a different kind of decision than renaming a tag. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Folded into #1588, which now covers these pages as well. Nothing is dropped; the commit is on that branch. Closing to keep the queue readable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1588, which fixed the question list and the two pages that embed
it. Three more pages carry their title as
h3and have noh1at all:The groups below them jump further than one level —
h6on the user page,h5on the badge page. Those becomeh2, one step under the title.Tags/index.tsxh3titleh1Users/index.tsxh3title,h6groupsh1,h2Badges/index.tsxh3title,h5groupsh1,h2fs-3,fs-6andfs-5carry the sizes the old tags had, so nothingchanges on screen. Checked with prettier, eslint and tsc.
Still open
The settings pages and the search results have no heading at all — not a wrong
level, none. Adding one means choosing wording and adding an i18n key across 45
language files, which is a different kind of decision than renaming a tag, so
it is not in here.
🤖 Generated with Claude Code