MINOR: actually throw in PooledByteBufAllocatorL - #1259
Merged
Conversation
no23reason
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
August 12, 2026 14:45
This comment has been minimized.
This comment has been minimized.
lidavidm
approved these changes
Aug 25, 2026
lidavidm
left a comment
lidavidm
left a comment
Member
There was a problem hiding this comment.
Thanks, can you rebase to pick up CI fixes?
There was a check in that class that looks like it throws an exception, but actually does not. This means that when that branch is hit, instead of an actionable error, the user gets a ClassCastException like ``` java.lang.ClassCastException: class io.netty.buffer.PooledDirectByteBuf cannot be cast to class io.netty.buffer.PooledUnsafeDirectByteBuf (io.netty.buffer.PooledDirectByteBuf and io.netty.buffer.PooledUnsafeDirectByteBuf are in unnamed module of loader org.springframework.boot.loader.launch.LaunchedClassLoader@5e9f23b4) ``` Actually throwing the exception prevents this.
This used to return size, which is wrong.
no23reason
force-pushed
the
buffer-patch-fail
branch
from
August 25, 2026 06:59
8b25da1 to
84d67a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
There was a check in that class that looks like it throws an exception, but actually does not. This means that when that branch is hit, instead of an actionable error, the user gets a ClassCastException like
Actually throwing the exception prevents this and should not break anything: there is still an exception being thrown, just a different type.
Also, make getNormalBufferCount actually return the count, not the size.