make sure pre saml login is enabled after saml is disabled - #13953

Open

DaanHoogland wants to merge 2 commits into

mainfrom

ghi12595-saml-disable-ldap-fallback

SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 25, 2026 in 3m 29s

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
41.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 482 in plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java

sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaA4nZlvUxr6NS6VP-Se&open=AaA4nZlvUxr6NS6VP-Se&pullRequest=13953

Check warning on line 127 in plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java

sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ31krd49U0dPV8fp&open=AaArJ31krd49U0dPV8fp&pullRequest=13953

View more details on SonarQubeCloud