add test ldap test command and button - #13954
Open
DaanHoogland wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13954 +/- ##
============================================
+ Coverage 19.72% 19.74% +0.01%
- Complexity 19941 19963 +22
============================================
Files 6371 6372 +1
Lines 575738 575782 +44
Branches 70471 70472 +1
============================================
+ Hits 113582 113684 +102
+ Misses 449810 449740 -70
- Partials 12346 12358 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.61% |
| Branch coverage | 18.81% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
DaanHoogland
force-pushed
the
ghi6934-test-ldap-connection
branch
from
August 22, 2026 21:19
c8a8518 to
e031775
Compare
|
GaOrtiga
reviewed
Aug 24, 2026
| import com.cloud.user.Account; | ||
|
|
||
| @APICommand(name = "testLdapConfiguration", description = "Tests connectivity to an LDAP server without saving a configuration", responseObject = SuccessResponse.class, | ||
| since = "4.23.0", requestHasSensitiveInfo = false, responseHasSensitiveInfo = false) |
Collaborator
There was a problem hiding this comment.
Suggested change
| since = "4.23.0", requestHasSensitiveInfo = false, responseHasSensitiveInfo = false) | |
| since = "24.0", requestHasSensitiveInfo = false, responseHasSensitiveInfo = false) |
| import com.cloud.exception.InvalidParameterValueException; | ||
| import com.cloud.user.Account; | ||
|
|
||
| @APICommand(name = "testLdapConfiguration", description = "Tests connectivity to an LDAP server without saving a configuration", responseObject = SuccessResponse.class, |
Collaborator
There was a problem hiding this comment.
Why isn't the command name "ldapTestConfiguration" (same as class name)? Would keep consistency and group it with other Ldap APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Fixes: #6934
a new test ldap connection command and button.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?