FINERACT-2684: WC - Ensure consistent disbursement date handling - #6348
Merged
adamsaghy merged 1 commit intoAug 28, 2026
Merged
Conversation
utafrali
reviewed
Aug 28, 2026
utafrali
left a comment
There was a problem hiding this comment.
Good refactoring that correctly fixes the findFirst()/getFirst() ordering bug by centralising chronologically-ordered disbursement lookups on the domain object. The main gap is that WorkingCapitalLoanMapper still gates setActualDisbursementDate on disbursedBy != null, leaving the full-loan timeline inconsistent with the summary mapper — directly at odds with the PR's stated goal.
adamsaghy
force-pushed
the
FINERACT-2684/consistent-disbursement-date-handling
branch
from
August 28, 2026 14:30
ac6343b to
75850f9
Compare
adamsaghy
deleted the
FINERACT-2684/consistent-disbursement-date-handling
branch
August 28, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.