Skip to content

FINERACT-2684: WC - Ensure consistent disbursement date handling - #6348

Merged
adamsaghy merged 1 commit into
apache:developfrom
adamsaghy:FINERACT-2684/consistent-disbursement-date-handling
Aug 28, 2026
Merged

FINERACT-2684: WC - Ensure consistent disbursement date handling#6348
adamsaghy merged 1 commit into
apache:developfrom
adamsaghy:FINERACT-2684/consistent-disbursement-date-handling

Conversation

@adamsaghy

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@utafrali utafrali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring that correctly fixes the findFirst()/getFirst() ordering bug by centralising chronologically-ordered disbursement lookups on the domain object. The main gap is that WorkingCapitalLoanMapper still gates setActualDisbursementDate on disbursedBy != null, leaving the full-loan timeline inconsistent with the summary mapper — directly at odds with the PR's stated goal.

@adamsaghy
adamsaghy force-pushed the FINERACT-2684/consistent-disbursement-date-handling branch from ac6343b to 75850f9 Compare August 28, 2026 14:30

@budaidev budaidev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy
adamsaghy merged commit 543ac2e into apache:develop Aug 28, 2026
91 checks passed
@adamsaghy
adamsaghy deleted the FINERACT-2684/consistent-disbursement-date-handling branch August 28, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants