fix / avoid throwing out hidden and filtered diagnostics - #106
Merged
davidramnero merged 5 commits intoAug 27, 2026
Merged
Conversation
davidramnero
commented
Aug 27, 2026
| cwd, | ||
| }); | ||
|
|
||
| // if spawn fails (e.g. ENOENT or permission denied) |
Collaborator
Author
There was a problem hiding this comment.
The diff for everything below has really weird formatting, what really happened is that all of the below is just indented with +1 tab due to promisifying the whole block, see new line of code at 571: await new Promise<void>((resolve, reject) => {
danmar
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, when e.g. switching severity level filtering like
info -> warning -> infothe diagnostics filtered out when switching towarningwould not re-appear when switching back toinfodue to being thrown out. This is now fixed.This is done through separating the storing and the displaying of diagnostics generated from analysis, and through a new property
hidden(boolean) in the diagnostic metadata that determines of a diagnostic should be visible.