docs: add the funnel chart type page - #11619
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 2m 7s —— View job Docs-only PR — no blocking issues. 0 high, 1 medium, 3 low. 3 inline comments posted.Full reviewTodos
ScopeThree files, docs-only, in What's correct
Findings
On #4: sibling pages seed a placeholder per configurable section — One caveat on verificationThe funnel chart implementation isn't in this repo — |
| description: Show how a value narrows from stage to stage, such as signup → activation → purchase. | ||
| --- | ||
|
|
||
| Funnel charts draw one bar per stage, centered on a shared midline, with a connector between each adjacent pair of stages. Each bar's width is proportional to its stage's value, so the figure narrows wherever values drop. Best for stage-to-stage conversion: how many users, orders, or events survive each step of a process. |
There was a problem hiding this comment.
Nit / opportunity: the repo already has recipes/data-modeling/funnels.mdx — "Implementing funnel analysis" with the packaged Funnels helper. That recipe produces exactly the step + conversions shape this chart consumes, so a one-line pointer here (and ideally a link back from the recipe) would make the modeling → visualization path discoverable. Something like: "To model the stages themselves, see Implementing funnel analysis."
Separately, that recipe doesn't appear in docs.json at all (grep -i funnel docs.json matches only the new chart page), so it may be unreachable from the sidebar. Out of scope for this PR, but worth a follow-up.
There was a problem hiding this comment.
Skipping this one. recipes/data-modeling/funnels.mdx is hidden: true in its frontmatter, so its absence from docs.json is deliberate rather than an oversight, and linking it from a listed page would surface it against that. Worth revisiting if the recipe is ever unhidden.
…ts legend, and reflow the recommendation rationale
|
Claude finished @igorlukanin's task in 1m 37s —— View job Re-review of
|
| # | Severity | Where | Issue |
|---|---|---|---|
| 1 | Low | funnel.mdx:42 |
Link target's own scope sentence (color-and-stacking.mdx:6) lists "bar, line, area, scatter, and heatmap" — not funnel |
| 2 | Low | funnel.mdx:48 |
New Legend section doesn't link to #legend; and that page says the legend appears "when a Color channel is assigned", which the funnel has none of |
| 3 | Low | funnel.mdx:6 |
Prior thread, still open: no cross-link to recipes/data-modeling/funnels.mdx |
Finding #3 is a re-affirm — the existing unresolved thread still applies, so I didn't post a duplicate.
Verification caveat (unchanged)
The funnel implementation still isn't in this repo, so the behavioral specifics — exactly-two-fields, the 36% of first / 20% of previous strings, which toggles default on, zero-value thin-line rendering, the white→dark label switch, shared font size — remain unverifiable from here. The Legend section added in this commit is in the same category. A human with access to the workbook code or a running instance needs to confirm them.
|
|
||
| ## Color | ||
|
|
||
| Each stage takes its own color from the palette selected in the **Palette** dropdown on the Style tab, in palette order. See [Palettes](/docs/explore-analyze/charts/configuration/color-and-stacking#palettes) for the built-in palettes and how to define a custom one. |
There was a problem hiding this comment.
The #palettes anchor resolves — color-and-stacking.mdx:24 is ## Palettes. 👍
One leftover from the previous round: that page's scope sentence (color-and-stacking.mdx:6) still says the Color-section settings "apply across bar, line, area, scatter, and heatmap charts". A reader following this link lands on a page that, by its own first paragraph, excludes the funnel. Either add funnel to that list, or narrow the claim there to the parts that are chart-type-specific. (Pie has the same gap, so it's a pre-existing seam — but this PR is what makes it reachable.)
|
|
||
| ## Legend | ||
|
|
||
| A legend naming each stage in its palette color is available in the **Legend** section of the Style tab, along with its placement. |
There was a problem hiding this comment.
Two notes on the new Legend section:
- No link out, unlike the Color section right above it.
color-and-stacking.mdx:87documents the same Legend section (Position: right/left/top/bottom; Hidden), so[Legend](/docs/explore-analyze/charts/configuration/color-and-stacking#legend)would save repeating the placement options here. - Possible contradiction with that page. It says "The legend appears when a Color channel is assigned" — the funnel has no Color channel (
## Fieldsabove says exactly two fields, Stage and Value), yet this page says a legend is available. Both can't be describing the same rule. Worth confirming which is right before linking them together.
Adds the Funnel page to the workbook chart-types docs — fields, conversion percentages on the connectors, data labels, and color — and lists it in the chart-types index. Also updates the recommendation section's never-recommended list to include the funnel.