Skip to content

cli: use configured endpoint for proxy lookup - #7232

Open
Sakshamm-Goyal wants to merge 1 commit into
docker:masterfrom
Sakshamm-Goyal:5797-ssh-proxy-config
Open

cli: use configured endpoint for proxy lookup#7232
Sakshamm-Goyal wants to merge 1 commit into
docker:masterfrom
Sakshamm-Goyal:5797-ssh-proxy-config

Conversation

@Sakshamm-Goyal

Copy link
Copy Markdown

- What I did

Use the configured Docker endpoint, rather than a connection helper's internal HTTP placeholder, when selecting per-daemon proxy configuration for container create/run and image build.

Fixes #5797.

- How I did it

Added a shared daemon-host resolver that prefers the original endpoint and falls back to the API client's host for test and compatibility paths. Added a regression covering an SSH endpoint whose API client uses http://docker.example.com internally.

- How to verify it

TZ=UTC ./scripts/with-go-mod.sh go test ./cli/command ./cli/command/container ./cli/command/image -count=1

Configure distinct default and ssh://daemon.example.com entries under proxies, then create or run a container through that SSH context. The container receives the SSH endpoint's proxy values.

- Human readable description for the release notes

Use per-daemon proxy configuration for SSH Docker contexts.

- A picture of a cute animal (not mandatory but encouraged)

Not included.

Signed-off-by: Saksham Goyal <sakshamgoyal1510@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proxy config is unable to distinguish ssh type target daemon host

1 participant