Small PR follow-ups - #84994
Open
jasonmalinowski wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Aug 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request applies follow-up fixes for NuGet restore isolation and cached language-server project alias handling.
Changes:
- Clears inherited NuGet package-source mappings.
- Trims cached aliases and removes empty entries.
Show a summary per file
| File | Description |
|---|---|
src/Tools/BuildBoss/PackageInstallCheckerUtil.cs |
Isolates generated NuGet mappings. |
src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectSystem.cs |
Normalizes cached aliases. |
Review details
Suppressed comments (1)
src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectSystem.cs:245
- This fixes a cache-loading behavior change but adds no regression coverage for the normalization. The existing cache tests only assert the raw
CachedMetadataReferencealiases, while thisGetAliasesconversion is where empty and whitespace-only entries are removed; please add a language-server/cache-loading test that verifies inputs such asglobal, , Foo,produce exactlyglobalandFoo.
=> item.Metadata["aliases"] is string aliases ? aliases.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries) : [];
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
akhera99
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow ups for #84948 (comment) and #84790 (comment)
Microsoft Reviewers: Open in CodeFlow