Skip to content

Small PR follow-ups - #84994

Open
jasonmalinowski wants to merge 2 commits into
dotnet:mainfrom
jasonmalinowski:pr-follow-ups
Open

Small PR follow-ups#84994
jasonmalinowski wants to merge 2 commits into
dotnet:mainfrom
jasonmalinowski:pr-follow-ups

Conversation

@jasonmalinowski

@jasonmalinowski jasonmalinowski commented Aug 21, 2026

Copy link
Copy Markdown
Member

Follow ups for #84948 (comment) and #84790 (comment)

Microsoft Reviewers: Open in CodeFlow

@jasonmalinowski jasonmalinowski self-assigned this Aug 21, 2026
Copilot AI lite review requested due to automatic review settings August 21, 2026 18:25
@jasonmalinowski
jasonmalinowski requested review from a team as code owners August 21, 2026 18:25
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request applies follow-up fixes for NuGet restore isolation and cached language-server project alias handling.

Changes:

  • Clears inherited NuGet package-source mappings.
  • Trims cached aliases and removes empty entries.
Show a summary per file
File Description
src/Tools/BuildBoss/PackageInstallCheckerUtil.cs Isolates generated NuGet mappings.
src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectSystem.cs Normalizes cached aliases.

Review details

Suppressed comments (1)

src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerProjectSystem.cs:245

  • This fixes a cache-loading behavior change but adds no regression coverage for the normalization. The existing cache tests only assert the raw CachedMetadataReference aliases, while this GetAliases conversion is where empty and whitespace-only entries are removed; please add a language-server/cache-loading test that verifies inputs such as global, , Foo, produce exactly global and Foo.
                => item.Metadata["aliases"] is string aliases ? aliases.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries) : [];
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants