Remove undeclared dependency on past.builtins - #1253
Open
Abhayindia wants to merge 1 commit into
Open
Conversation
dronekit/__init__.py imported basestring from past.builtins, but python-future was never listed as an install dependency, so a fresh `pip install dronekit` fails with ModuleNotFoundError: No module named 'past' as soon as dronekit is imported (dronekit#1252). basestring is only needed for Python 2/3 compatibility, so replace the external import with the same sys.version_info gating already used a few lines above for the collections.abc change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1252.
dronekit/__init__.pyimportsbasestringfrompast.builtins, butpython-future(which providespast) was never listed as a dependency insetup.py. A freshpip install dronekitfails immediately on import.basestringis only needed for Python 2/3 compatibility, so this replaces the import with the samesys.version_infogating already used a few lines up for thecollections.abcchange - no new dependency needed.Confirmed the module is genuinely gone and the import still works: