Skip to content

SearchBar cleanup - #1794

Merged
danirabbit merged 11 commits into
masterfrom
jeremypw/SearchBar/cleanup
Aug 24, 2026
Merged

SearchBar cleanup#1794
danirabbit merged 11 commits into
masterfrom
jeremypw/SearchBar/cleanup

Conversation

@jeremypw

@jeremypw jeremypw commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Best reviewed with whitespace hidden and one commit at a time.

Minor changes

  • Update header style
  • Consistent ordering of public/private properties and functions
  • Modern widget creation style
  • Minimise namespace use
  • Shorten some lines

Although the diff is substantial none of these changes affect the code logic. Ignore 9cb98d9 which is later reverted and made into a separate PR.

@jeremypw jeremypw added this to the 8.3.x milestone Aug 23, 2026
@jeremypw
jeremypw marked this pull request as ready for review August 23, 2026 17:31
@jeremypw
jeremypw requested a review from a team August 23, 2026 17:32
@danirabbit
danirabbit force-pushed the jeremypw/SearchBar/cleanup branch from 71b2b56 to 72db6ee Compare August 24, 2026 16:20

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking this up into commits that were easy to review!

@danirabbit
danirabbit merged commit ef25ef0 into master Aug 24, 2026
6 checks passed
@danirabbit
danirabbit deleted the jeremypw/SearchBar/cleanup branch August 24, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants