[rig-claude] Improve Claude dynamic-workflow compatibility for rig - #476
Merged
Merged
Conversation
Add missing s.record(X) row for JSON Schema additionalProperties: X
patterns -- common in real Claude dynamic workflows that output count maps,
label->value maps, and similar open-ended string-keyed objects.
Also add s.int("d") to match the s.string("d") and s.number("d")
pattern already in the table; omitting it was inconsistent.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — changes are accurate and clearly explained; approving.
📋 Key Themes & Highlights
Key Themes
- Both new rows (
s.int("d")ands.record(X)) are verified against the actualrig.tsimplementation and are correct - The
s.recordrow correctly maps theadditionalProperties: XJSON Schema pattern - Prose update clearly contextualises when to prefer
s.recordovers.object
Positive Highlights
- ✅ Fills a real discoverability gap for
additionalProperties→s.record— the most common dead-end for Claude workflow porters - ✅ Adds the missing
s.int("d")row, completing the consistency pattern already established bys.string("d")ands.number("d") - ✅ The inline example (
s.record(s.int)for count maps) makes usage immediately concrete
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 20.1 AIC · ⌖ 4.1 AIC · ⊞ 6.3K
Comment /matt to run again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility gap addressed
The schema conversion table in
skills/rig/references/claude-workflow-conversion.mdwas missing two entries that a Claude dynamic-workflow user would frequently encounter when porting schemas:s.record(X)foradditionalProperties: X— Claude dynamic workflows commonly return count maps, label→value maps, and other open-ended string-keyed objects using the{ type: "object", additionalProperties: X }JSON Schema pattern. There was no row for this in the table, leaving porters to discovers.recordon their own.s.int("d")for{ type: "integer", description: "d" }— The table already hads.string("d")ands.number("d")but nots.int("d"). The inconsistency would confuse someone scanning the table top-to-bottom.Why this improves transfer
The schema conversion table is the first reference a Claude dynamic-workflow user consults when they hit a type they can't map. Missing
s.recordcaused a dead-end for anyone porting a workflow whose output usedadditionalProperties(e.g.extCounts: { type: "object", additionalProperties: { type: "integer" } }). Adding the row plus an explanatory note makes the mapping mechanical and obviates a separate search through the API docs.Files changed
skills/rig/references/claude-workflow-conversion.md— addeds.record(X)row and updated the prose note; addeds.int("d")row for consistencyValidation run
Docs-only change; no code or samples modified. No extra validation required beyond reviewing the edited file for correct links and content.
Remaining intentional differences
None introduced. All existing intentional differences (failure holes, pipeline stage signature, budget units, no sandbox restrictions, no resume journal) remain documented in the "Behavior differences" section.