Fix RuboCop offenses introduced by a newer release - #853
Merged
Conversation
Autocorrect for offenses introduced by a newer RuboCop release within the Gemfile's ~> 1.85 constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A newer RuboCop release within the Gemfile's
~> 1.85constraint flags three offenses on main, failing therubocopjob on every open PR. This applies RuboCop's own autocorrections:lib/http/headers.rb:Layout/ExtraSpacingno longer accepts the alignedthenkeywords inHeaders.coerce. If the alignment is worth keeping, the alternative is disabling the cop; itsAllowForAlignmentoption is already on by default and no longer covers this case.lib/http/retriable/performer.rb:Style/DirectiveScopewantsrubocop:disable-nextinstead of a disable/enable pair around a single statement.bundle exec rubocop: 135 files inspected, no offenses detected.