Externalise cache keys to prevent unneeded invalidation - #3922
Open
pljones wants to merge 1 commit into
Open
Conversation
mcfnord
reviewed
Aug 22, 2026
pljones
force-pushed
the
cache-keys
branch
3 times, most recently
from
August 23, 2026 15:31
81278cc to
fdae3db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
I noticed whilst I've been working on
autobuild.shthat every change invalidates all the caches. Becauseautobuild.shitself is included in the cache key calculation. This change replaces that mechanism on macOS and Windows with am externalised list of dependencies. It adds the same mechanism to iOS, which lacked caching.Github cache clean up will remove unused cache entries with no need to have the cache consumer included in the cache key.
(My work in progress on the Android build uses the same approach, which is where this comes from.)
Scope, guidance, testing and review by myself, coding my VSCode Github CoPilot.
CHANGELOG: Build: improve cache persistence
Context: Fixes an issue?
Caching should depend on what is being cached, rather than the cache consumer.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested against the current branch in my own repository before raising the PR here.
What is missing until this pull request can be merged?
Need to do some more testing.
Checklist
AUTOBUILD: Please build all targets