ENH Add Scenario progress foundation - #2372
Open
Roman Lutz (romanlutz) wants to merge 6 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This was referenced Aug 12, 2026
Roman Lutz (romanlutz)
force-pushed
the
copilot/romanlutz-scenario-pr-01-progress-upstream
branch
from
August 21, 2026 03:40
2f6c715 to
c8b2b18
Compare
Roman Lutz (romanlutz)
force-pushed
the
copilot/romanlutz-scenario-pr-01-progress-upstream
branch
from
August 25, 2026 00:20
6ccdf08 to
a9b420e
Compare
Roman Lutz (romanlutz)
marked this pull request as ready for review
August 25, 2026 03:43
Roman Lutz (romanlutz)
changed the title
Roman Lutz (romanlutz)
force-pushed
the
copilot/romanlutz-scenario-pr-01-progress-upstream
branch
from
August 25, 2026 03:45
a9b420e to
8f52a35
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d02c2d5-b499-4f78-a04d-03bffa750817
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47a96cf7-36b1-482c-ab17-87cbf97afbdf
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d02c2d5-b499-4f78-a04d-03bffa750817
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5d02c2d5-b499-4f78-a04d-03bffa750817
Roman Lutz (romanlutz)
force-pushed
the
copilot/romanlutz-scenario-pr-01-progress-upstream
branch
from
August 25, 2026 06:24
8f52a35 to
8d830a2
Compare
Richard Lundeen (rlundeen2)
approved these changes
Aug 26, 2026
| ScenarioRunState.CANCELLED, | ||
| ) | ||
| plan = self._load_run_plan(scenario_result=scenario_result) | ||
| total_attacks = sum(len(group.seed_group_ids) for group in plan.atomic_groups) if plan is not None else 0 |
Contributor
There was a problem hiding this comment.
(GHCP Generated): Nit: For legacy runs without a persisted plan, this reports total_attacks=0, but the total is unknown rather than zero. The CLI then displays “0 planned attacks,” which is misleading. Could this be nullable or omitted for legacy runs instead?
| """ | ||
| if limit < 1 or limit > 100: | ||
| raise ValueError("Scenario run history limit must be between 1 and 100.") | ||
| entries = self._query_scenario_result_entries( |
Contributor
There was a problem hiding this comment.
(GHCP Generated): Nit: _query_scenario_result_entries() orders by completion_time DESC, so active runs with no completion time sort after completed runs and can fall outside this limit even though the endpoint says “most recent first.” Could this history query sort on a timestamp populated for every run, such as coalesce(completion_time, creation_time)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds persistent versioned Scenario run plans, stable logical work identities, backend-authoritative sizing, incremental progress cursors, and corrected timing/resume semantics. Planned units deduplicate repeated logical objectives while execution attempts remain observable.
What this layer adds
ScenarioRunPlanand progress models persisted in Scenario result metadata.Visual contract
Stack
This is 1 of 7 in native GitHub Stack #2390 and targets
main.See the full implementation, screenshots, walkthrough, validation, and operational notes.
Validation
Compatibility note
Prepended-conversation request converters now default to user-role messages, and strict non-chat targets can reject excluded roles. This intentional behavior change is isolated in this foundation layer.