MAINT Add registry names to target table - #2479
Open
Behnam (behnam-o) wants to merge 1 commit into
Open
Conversation
| ) | ||
|
|
||
| expect(screen.getByText('Registry Name')).toBeInTheDocument() | ||
| expect(screen.getByText('openai_chat_gpt4')).toBeInTheDocument() |
Contributor
There was a problem hiding this comment.
NIT: do we want to test that registry names are also present when round robin row is expanded (maybe in the test around ~line 350)? and also for active target
Justin Song (jsong468)
approved these changes
Aug 24, 2026
Contributor
|
is there a reason we didn't do this before? 😄 it seems pretty intuitive to have this... |
Roman Lutz (romanlutz)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a column to the targets table on the web UI that shows the targets' registry names.
Today we only show the target type (python class), model, endpoint, etc. but not a human-readable friendly name for each entry. The registry name of each target is a good field that serves that purpose.
This is also helpful when multiple targets are registered that have similar model + endpoint + class but differ in some other param (e.g. temprature), usually the registry name is set in a way to clarify that. ( for example, here are 2 default targets we register today that look similar on the UI but the registry name clarifies what's different between them)
