Fix crash on malformed object destructuring assignment - #63972
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Open
Fix crash on malformed object destructuring assignment#63972Mateusz Burzyński (Andarist) wants to merge 1 commit into
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
August 23, 2026 17:31
View session
| } | ||
|
|
||
| func (tx *classFieldsTransformer) visitObjectAssignmentElement(node *ast.Node) *ast.Node { | ||
| debug.Assert(node != nil && ast.IsObjectBindingOrAssignmentElement(node)) |
Contributor
Author
There was a problem hiding this comment.
It seems to me the assert here (and I've seen similar cases in the past) assumes a non-malformed source code. But those transformer paths still run over malformed nodes and it's the easiest to accept such subtrees
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a compiler regression test for malformed object destructuring and prevents the class-fields transformer panic.
Changes:
- Removes the triggering assertion.
- Adds malformed-input test coverage and generated baselines.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/transformers/estransforms/classfields.go |
Changes malformed assignment handling. |
tsc/testdata/tests/cases/compiler/malformedObjectDestructuringAssignmentClassFields.ts |
Adds the regression input. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentClassFields.errors.txt |
Records diagnostics. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentClassFields.js |
Records emit output. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentClassFields.symbols |
Records symbols. |
tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentClassFields.types |
Records inferred types. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| @@ -3318,7 +3318,6 @@ func (tx *classFieldsTransformer) visitAssignmentRestProperty(node *ast.Node) *a | |||
| } | |||
|
|
|||
| func (tx *classFieldsTransformer) visitObjectAssignmentElement(node *ast.Node) *ast.Node { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #63963