Avoid allocations when checking project reference declaration directories - #63977
Open
auvred wants to merge 1 commit into
Open
Avoid allocations when checking project reference declaration directories#63977auvred wants to merge 1 commit into
auvred wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces allocation-heavy path concatenation with Path.ContainsPath when checking project-reference declaration directories.
Changes:
- Uses canonical path containment checks in both directions.
- Avoids ephemeral string allocations in a language-server hot path.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63976
ContainsPathdoes the same check without extra allocationsTypeScript/tsc/internal/tspath/path.go
Lines 1085 to 1093 in e9e4774
Before:
handled method 'textDocument/references' (32) in 3.071585458sAfter:
handled method 'textDocument/references' (20) in 2.692099625s