test: support inspecting WPTs in child processes - #65510
Open
panva wants to merge 2 commits into
Open
Conversation
Describe how to run WPT modules, select source files or generated tests, and choose the existing thread or process backend. Document the WPTRunner options and remove duplicated run instructions. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Add WPT_INSPECT to launch one generated main-thread test with --inspect-brk on an available port. Forward debugger stderr so an inspector client can attach while the child is paused. Require an exact generated test path and reject worker variants, whose test code runs in a nested Worker. Cover backend precedence, selector errors, inspector attachment, and clean shutdown. Refs: nodejs#51854 Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added
the
commit-queue-rebase
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65510 +/- ##
==========================================
- Coverage 90.14% 90.12% -0.02%
==========================================
Files 751 751
Lines 252709 252709
Branches 47557 47560 +3
==========================================
- Hits 227800 227750 -50
- Misses 16206 16255 +49
- Partials 8703 8704 +1 🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Aug 24, 2026
avivkeller
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the inspector debugging limitation described in #51854 and builds on the selectable thread/process WPT backend introduced in c757550.
WPT specs running in worker threads make attaching an inspector to an individual test difficult, this adds an opt-in
WPT_INSPECTmode that:--inspect-brk=0Also document WPT execution backends (which I failed to do in c757550), source and generated test selectors, runner options, and the inspector workflow.