Skip to content

test(cli): three e2e spawners name the entrypoint they actually reach #11462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Aug 24, 2026
+69 −12
Merged

test(cli): three e2e spawners name the entrypoint they actually reach #11462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions packages/cli/test/serve-mcp-capability-collision.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,27 @@ import { mkdtempSync, rmSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { E2E_SECRET_KEY, childEnv, randomPort } from './helpers/serve-process.js';
import { E2E_SECRET_KEY, TSX, childEnv, randomPort } from './helpers/serve-process.js';

const HERE = resolve(fileURLToPath(import.meta.url), '..');
/** `bin/run.js` — the SHIPPED entrypoint, i.e. the one the card's repro names. */
const CLI = resolve(HERE, '../bin/run.js');
/**
* `bin/run-dev.js` through `tsx` — the SOURCE entrypoint, like the ~20 sibling
* e2e files in this directory.
*
* ⛔ NOT `bin/run.js`. This file used to spell that one and call it "the SHIPPED
* entrypoint"; the claim was never true here (#11317). The boot below pins
* `NODE_ENV=development` on the child for the `--dev` admin seed, and
* @oclif/core 4.13.3 skips its TypeScript path lookup only when `isProd()` —
* `!['development', 'test'].includes(process.env.NODE_ENV ?? '')`. Under that
* value oclif rewrites the command target from the declared `./dist/commands`
* to `./src/commands` and transpiles, so `packages/cli/dist` is never consulted
* whichever stub is named. `serve-node-env-production-default.e2e.test.ts` is
* the file that genuinely reaches the built artifact, and it gets there by
* leaving `NODE_ENV` UNSET — the value that disables the reroute. Restoring
* `bin/run.js` here without dropping the `NODE_ENV` pin below is a no-op with a
* false comment attached.
*/
const CLI = resolve(HERE, '../bin/run-dev.js');

/** The consumer's real identity — see `serve-capability-identity.test.ts`. */
const CONSUMER_PLUGIN_ID = 'com.objectstack.connector.mcp';
Expand Down Expand Up @@ -106,7 +122,7 @@ const children: ChildProcessWithoutNullStreams[] = [];

function boot(env: Record<string, string | undefined>, waitFor: RegExp): Promise<ChildProcessWithoutNullStreams> {
return new Promise((resolveBoot, rejectBoot) => {
const child = spawn(process.execPath, [CLI, 'serve', '-p', port, '--dev'], {
const child = spawn(TSX, [CLI, 'serve', '-p', port, '--dev'], {
cwd: dir,
stdio: ['pipe', 'pipe', 'pipe'],
// `childEnv`, not a bare `...process.env`: the vitest worker exports
Expand All @@ -127,6 +143,9 @@ function boot(env: Record<string, string | undefined>, waitFor: RegExp): Promise
OS_SECRET_KEY: E2E_SECRET_KEY,
// The dev-admin seed the key mint signs in as is gated on this, and
// vitest exports `test`.
// Still passed explicitly although `bin/run-dev.js` assigns it too: the
// shim's assignment runs after its own static imports have evaluated,
// so only the child env pins the value for the whole process lifetime.
NODE_ENV: 'development',
...env,
}),
Expand Down
27 changes: 23 additions & 4 deletions packages/cli/test/serve-mcp-stdio-answers.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,27 @@ import { mkdtempSync, rmSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { E2E_SECRET_KEY, childEnv, randomPort } from './helpers/serve-process.js';
import { E2E_SECRET_KEY, TSX, childEnv, randomPort } from './helpers/serve-process.js';

const HERE = resolve(fileURLToPath(import.meta.url), '..');
/** `bin/run.js` — the SHIPPED entrypoint, i.e. the one the card's repro names. */
const CLI = resolve(HERE, '../bin/run.js');
/**
* `bin/run-dev.js` through `tsx` — the SOURCE entrypoint, like the ~20 sibling
* e2e files in this directory.
*
* ⛔ NOT `bin/run.js`. This file used to spell that one and call it "the SHIPPED
* entrypoint"; the claim was never true here (#11317). The boot below pins
* `NODE_ENV=development` on the child for the `--dev` admin seed, and
* @oclif/core 4.13.3 skips its TypeScript path lookup only when `isProd()` —
* `!['development', 'test'].includes(process.env.NODE_ENV ?? '')`. Under that
* value oclif rewrites the command target from the declared `./dist/commands`
* to `./src/commands` and transpiles, so `packages/cli/dist` is never consulted
* whichever stub is named. `serve-node-env-production-default.e2e.test.ts` is
* the file that genuinely reaches the built artifact, and it gets there by
* leaving `NODE_ENV` UNSET — the value that disables the reroute. Restoring
* `bin/run.js` here without dropping the `NODE_ENV` pin below is a no-op with a
* false comment attached.
*/
const CLI = resolve(HERE, '../bin/run-dev.js');

const CONFIG = `
export default {
Expand Down Expand Up @@ -101,7 +117,7 @@ interface Booted {
*/
function boot(env: Record<string, string | undefined>, waitFor: RegExp): Promise<Booted> {
return new Promise((resolveBoot, rejectBoot) => {
const child = spawn(process.execPath, [CLI, 'serve', '-p', port, '--dev'], {
const child = spawn(TSX, [CLI, 'serve', '-p', port, '--dev'], {
cwd: dir,
stdio: ['pipe', 'pipe', 'pipe'],
// `childEnv`, not a bare `...process.env`: the vitest worker exports
Expand All @@ -123,6 +139,9 @@ function boot(env: Record<string, string | undefined>, waitFor: RegExp): Promise
// Explicit, not inherited: the dev-admin seed this fixture signs in as
// is hard-gated on `NODE_ENV === 'development'`, and vitest exports
// `test`, which would leave the DB user-less and the mint unauthorized.
// Still passed explicitly although `bin/run-dev.js` assigns it too: the
// shim's assignment runs after its own static imports have evaluated,
// so only the child env pins the value for the whole process lifetime.
NODE_ENV: 'development',
...env,
}),
Expand Down
27 changes: 23 additions & 4 deletions packages/cli/test/serve-stdio-stdout-purity.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,27 @@ import { mkdtempSync, rmSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import { E2E_SECRET_KEY, childEnv, randomPort } from './helpers/serve-process.js';
import { E2E_SECRET_KEY, TSX, childEnv, randomPort } from './helpers/serve-process.js';

const HERE = resolve(fileURLToPath(import.meta.url), '..');
/** `bin/run.js` — the SHIPPED entrypoint, i.e. the one the card's repro names. */
const CLI = resolve(HERE, '../bin/run.js');
/**
* `bin/run-dev.js` through `tsx` — the SOURCE entrypoint, like the ~20 sibling
* e2e files in this directory.
*
* ⛔ NOT `bin/run.js`. This file used to spell that one and call it "the SHIPPED
* entrypoint"; the claim was never true here (#11317). The boot below pins
* `NODE_ENV=development` on the child for the `--dev` admin seed, and
* @oclif/core 4.13.3 skips its TypeScript path lookup only when `isProd()` —
* `!['development', 'test'].includes(process.env.NODE_ENV ?? '')`. Under that
* value oclif rewrites the command target from the declared `./dist/commands`
* to `./src/commands` and transpiles, so `packages/cli/dist` is never consulted
* whichever stub is named. `serve-node-env-production-default.e2e.test.ts` is
* the file that genuinely reaches the built artifact, and it gets there by
* leaving `NODE_ENV` UNSET — the value that disables the reroute. Restoring
* `bin/run.js` here without dropping the `NODE_ENV` pin below is a no-op with a
* false comment attached.
*/
const CLI = resolve(HERE, '../bin/run-dev.js');

const CONFIG = `
export default {
Expand Down Expand Up @@ -93,7 +109,7 @@ interface Booted {
*/
function boot(env: Record<string, string | undefined>, waitFor: RegExp): Promise<Booted> {
return new Promise((resolveBoot, rejectBoot) => {
const child = spawn(process.execPath, [CLI, 'serve', '-p', port, '--dev'], {
const child = spawn(TSX, [CLI, 'serve', '-p', port, '--dev'], {
cwd: dir,
stdio: ['pipe', 'pipe', 'pipe'],
// `childEnv`, not a bare `...process.env`: the vitest worker exports
Expand All @@ -117,6 +133,9 @@ function boot(env: Record<string, string | undefined>, waitFor: RegExp): Promise
OS_SECRET_KEY: E2E_SECRET_KEY,
// Explicit, not inherited: the dev-admin seed the mint signs in as is
// hard-gated on `NODE_ENV === 'development'`, and vitest exports `test`.
// Still passed explicitly although `bin/run-dev.js` assigns it too: the
// shim's assignment runs after its own static imports have evaluated,
// so only the child env pins the value for the whole process lifetime.
NODE_ENV: 'development',
...env,
}),
Expand Down
Loading