Skip to content

[AI-3] Register AI features and resolve their models at runtime - #24888

Open
tangopium wants to merge 1 commit into
feature/66020-pr09-environment-provisioningfrom
feature/66020-pr10-features-and-runtime
Open

[AI-3] Register AI features and resolve their models at runtime#24888
tangopium wants to merge 1 commit into
feature/66020-pr09-environment-provisioningfrom
feature/66020-pr10-features-and-runtime

Conversation

@tangopium

@tangopium tangopium commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Ticket

AI-3

What are you trying to accomplish?

PR 10 of 11 in the AI-3 stack. Adds the feature registry (each AI feature declares its kind, required capabilities and whether its model may be overridden, following the FeatureDecisions idiom) and the AI models page that binds each registered feature to a model. Options are never hidden: a model is selectable, selectable with a warning when a required capability is unknown, or disabled with the reason when it is ruled out. Llm::Runtime is the single resolver (override, then binding, then connection default, otherwise unbound) and fails closed with a machine-readable reason rather than substituting another model. Bindings reference models by identifier string, never by foreign key, so they survive a model disappearing. This is the interface #77781 and #77783 consume.

Merge checklist

  • Added/updated tests
  • Behind the llm_connection feature flag

Stacked on #24887.

@github-actions

Copy link
Copy Markdown

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@github-actions

Copy link
Copy Markdown

Caution

The Enterprise plan field is not set on the work package

Details:

Please make sure that:

  • The work package Enterprise plan field is set

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd21ec891b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/models/llm_feature_binding.rb
Comment thread app/controllers/admin/llm_feature_bindings_controller.rb Outdated
Comment thread app/services/llm/runtime.rb Outdated
@tangopium
tangopium force-pushed the feature/66020-pr10-features-and-runtime branch from bd21ec8 to de1e33c Compare August 22, 2026 15:05
@tangopium tangopium changed the title [#66020] Register AI features and resolve their models at runtime [AI-3] Register AI features and resolve their models at runtime Aug 22, 2026
@tangopium
tangopium force-pushed the feature/66020-pr10-features-and-runtime branch from de1e33c to d435975 Compare August 22, 2026 15:26
@tangopium
tangopium force-pushed the feature/66020-pr10-features-and-runtime branch from d435975 to 48829cb Compare August 22, 2026 15:51
Adds the feature registry: each AI feature declares its kind, the capabilities it requires and whether administrators may override its model, following the FeatureDecisions idiom and living in lib_static for the same reload-safety reason. The AI models page then lets an administrator bind each registered feature to a model, fed by a query that never hides a model: an option is selectable, selectable with a warning when a required capability is unknown, or disabled with the reason when it is ruled out.

Llm::Runtime is the single place a feature's model is resolved: explicit override, then binding, then the connection default, and otherwise unbound. It fails closed with a machine-readable reason rather than substituting another model, because a text transform with a different model is a different feature. Bindings reference models by identifier string, never by foreign key, so a binding survives its model disappearing and the dangling state is derived, not stored.

With something to bind, the connection form gains the default embedding model selector, offering only models actually known to embed, and the destructive dialogs now name the features that would be affected.

Part 10 of the AI-3 stack.

https://community.openproject.org/work_packages/66020
@tangopium
tangopium force-pushed the feature/66020-pr10-features-and-runtime branch from 48829cb to 426df28 Compare August 22, 2026 16:16
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]
  • rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24888, linked for reference only):

- `rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]`
- `rspec ./spec/features/work_packages/table/switch_types_spec.rb[1:1:2]`

Treat this as a standalone task, unrelated to PR #24888. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24888 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @tangopium to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @tangopium, and request a review from @tangopium.
On every commit, set @tangopium as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@tangopium
tangopium requested a review from thykel August 22, 2026 21:40
@tangopium tangopium self-assigned this Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant