chore: use registry.osism.tech instead of registry.osism.cloud - #2623
Merged
Conversation
registry.osism.tech is the registry hostname in use, replace the remaining registry.osism.cloud references with it. Covers the container base image in the Containerfile, the default registry of the check command, the SBOM image defaults of the sync command, and the expected values in their unit tests. The CHANGELOG entry is left alone, it records what an earlier release did. Assisted-by: Claude:claude-opus-5 Signed-off-by: Christian Berendt <berendt@osism.tech>
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The change redirects base-image and SBOM pulls to a different registry, so an unavailable or incorrectly configured endpoint would break builds and image checks, while an untrusted registry could supply container contents that get executed or deployed. Reverting restores future pulls, but it cannot undo artifacts already built or deployed from the new registry.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the remaining
registry.osism.cloudreferences withregistry.osism.tech, the registry hostname in use.Touched:
Containerfile— container base imageosism/commands/check.py— default registry and its help textosism/commands/sync.py— SBOM image defaults and help textstests/unit/commands/test_check.py,tests/unit/commands/test_sync.py—expected values
The
CHANGELOG.mdentry mentioningregistry.osism.cloudis leftuntouched, it records what an earlier release actually did.
🤖 Generated with Claude Code