ext/standard: declare true as the return type of register_tick_function() - #23432
Open
lacatoire wants to merge 1 commit into
Open
ext/standard: declare true as the return type of register_tick_function()#23432lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
lacatoire
force-pushed
the
fix/register-tick-function-true
branch
2 times, most recently
from
August 24, 2026 07:28
14cff0b to
218d081
Compare
Member
|
Also seems true. But I also don't think this needs a test. This is quite an improvement rather then a bug and we don't need regression test for that. |
Member
Agreed. The test can't really test that |
…on() The function either throws on an invalid callback or appends the entry to the tick list and returns true; php_add_tick_function() returns void, so there is nothing that could report a failure.
lacatoire
force-pushed
the
fix/register-tick-function-true
branch
from
August 24, 2026 08:06
218d081 to
186efd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register_tick_function()is declaredboolbut has no failure path beyond the ZPP step, which throws.php_add_tick_function()andzend_llist_add_element()are bothvoid, so no status is being dropped.trueis the only value ever returned.unregister_tick_function()is alreadyvoid, andksort(),asort(), andnatsort()in the same stub already declaretrue, so this follows existing practice.Changes:
basic_functions.stub.php(bool→true), regenerated arginfo, added test.