Conversation
stonebuzz
marked this pull request as draft
August 24, 2026 10:17
stonebuzz
marked this pull request as ready for review
August 24, 2026 13:13
Rom1-B
requested changes
Aug 24, 2026
| if (isset($_POST['target']) && !in_array($_POST['target'], ['_blank', 'right'], true)) { | ||
| unset($_POST['target']); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| foreach (['folderLinks', 'useSelection', 'useLines', 'useIcons', 'closeSameLevel', 'itemName', 'locationName'] as $field) { | |
| if (isset($_POST[$field])) { | |
| $_POST[$field] = (int) $_POST[$field]; | |
| } | |
| } |
Comment on lines
36
to
+45
| if (isset($_POST['plugin_treeview_user_preferences_save'])) { | ||
| $pref->update($_POST); | ||
| if (!($own_id = $pref->checkIfPreferenceExists(Session::getLoginUserID()))) { | ||
| $own_id = $pref->addDefaultPreference(Session::getLoginUserID()); | ||
| if (!$own_id) { | ||
| Session::addMessageAfterRedirect(__s('Unable to save preferences', 'treeview'), false, ERROR); | ||
| Html::back(); | ||
| } | ||
| } | ||
|
|
||
| $pref->update(['id' => $own_id, 'show_on_load' => (int) ($_POST['show_on_load'] ?? 0)]); |
Contributor
There was a problem hiding this comment.
Can you add a functional test for the preference-ownership fix and the entity/right filtering in getNodesFromDb()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fix item validation when loading trees
Screenshots (if appropriate):