Skip to content

Handle parentheses around MatchSequence more correctly - #863

Merged
lieryan merged 8 commits into
masterfrom
lieryan-match-case-corner-cases
Aug 25, 2026
Merged

Handle parentheses around MatchSequence more correctly#863
lieryan merged 8 commits into
masterfrom
lieryan-match-case-corner-cases

Conversation

@lieryan

@lieryan lieryan commented Aug 20, 2026

Copy link
Copy Markdown
Member

Description

Handle various corner cases around MatchSequence. It's complicated by the fact that the MatchSequence syntax allows multiple kinds of parentheses and even no parentheses and the ast doesn't give us any clue which is being used.

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

@lieryan
lieryan force-pushed the lieryan-match-case-corner-cases branch from 8cc9afe to 5de4db7 Compare August 20, 2026 16:31
@lieryan lieryan changed the title Handle MatchSequence with different parentheses more correctly Handle parentheses around MatchSequence more correctly Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.97980% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.28%. Comparing base (5ad2c6a) to head (2d52f55).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
rope/refactor/patchedast.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         134      134           
  Lines       26442    26534   +92     
=======================================
+ Hits        25194    25284   +90     
- Misses       1248     1250    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lieryan lieryan added this to the 1.15.0 milestone Aug 25, 2026
@lieryan
lieryan enabled auto-merge August 25, 2026 17:35
@lieryan
lieryan merged commit d2c5127 into master Aug 25, 2026
43 checks passed
@lieryan
lieryan deleted the lieryan-match-case-corner-cases branch August 25, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant