Skip to content

gh-144712: Export _Py_jit_entry symbol via PyAPI_DATA - #145840

Open
ashm-dev wants to merge 3 commits into
python:mainfrom
ashm-dev:gh-144712
Open

gh-144712: Export _Py_jit_entry symbol via PyAPI_DATA#145840
ashm-dev wants to merge 3 commits into
python:mainfrom
ashm-dev:gh-144712

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Mar 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@ashm-dev
ashm-dev requested a review from markshannon as a code owner March 11, 2026 17:31
@bedevere-app bedevere-app Bot mentioned this pull request Mar 11, 2026
Open
Fidget-Spinner
Fidget-Spinner approved these changes Mar 12, 2026
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @jjhelmus does this fix your problems?

@ashm-dev
ashm-dev requested a review from Fidget-Spinner April 15, 2026 10:52
@Fidget-Spinner

Fidget-Spinner commented Apr 15, 2026

Copy link
Copy Markdown
Member

@diegorusso does this look right to you?

@diegorusso

diegorusso commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Please hold on that. This #146071 needs to go in first and likely this needs to be adapted.

@ashm-dev

ashm-dev commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@diegorusso #146071 was merged on 2026-05-02. I've rebased onto current main and adapted the initializer (_PyJIT → _PyJIT_Entry). Could you take another look? @Fidget-Spinner the change is small enough that your earlier approval should still apply — pinging in case you'd like to re-confirm before merge.

@ashm-dev

ashm-dev commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

The Ubuntu (free-threading) / build and test failure is unrelated — the runner received a shutdown signal mid-run (exit code 143, "runner has received a shutdown signal"). All tests passed up to that point. A rerun should be green.

@ashm-dev

ashm-dev commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@Fidget-Spinner @diegorusso, could you please take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashm-dev @Fidget-Spinner @diegorusso