Skip to content

gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS - #156302

Open
advitrocks9 wants to merge 2 commits into
python:mainfrom
advitrocks9:fix-155193
Open

gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS#156302
advitrocks9 wants to merge 2 commits into
python:mainfrom
advitrocks9:fix-155193

Conversation

@advitrocks9

@advitrocks9 advitrocks9 commented Aug 23, 2026

Copy link
Copy Markdown

The 3.15 What's New lists urlsafe_b64decode() as one of the decoders that got canonical, but it never got the parameter:

>>> base64.urlsafe_b64decode(b'aGk=', canonical=True)
TypeError: urlsafe_b64decode() got an unexpected keyword argument 'canonical'

It doesn't call b64decode(), it calls binascii.a2b_base64() directly with a fixed set of arguments, so widening b64decode() in GH-146312 didn't affect it. This drops it from the bullet, per gpshead on the issue.

I went through the other bullets in the base64 section and checked them against the signatures. This is the only one that's off.

The NEWS entry for the same change (now in Misc/NEWS.d/3.15.0b1.rst) says the base16 decoders got canonical, but none did: b16decode() and binascii.a2b_hex() are unchanged. Removed base16 from that entry too.

Docs only, so skip news. Needs a backport to 3.15.

@advitrocks9
advitrocks9 requested a review from AA-Turner as a code owner August 23, 2026 20:33
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Aug 23, 2026
@python-cla-bot

python-cla-bot Bot commented Aug 23, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@read-the-docs-community

read-the-docs-community Bot commented Aug 23, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34196934 | 📁 Comparing c5bf8b9 against main (53d2e14)

  🔍 Preview build  

2 files changed
± whatsnew/3.15.html
± whatsnew/changelog.html

@picnixz

picnixz commented Aug 23, 2026

Copy link
Copy Markdown
Member

Can you check if a NEWS entry needs to be amended as well?

@advitrocks9 advitrocks9 changed the title gh-155193: Remove urlsafe_b64decode from the *canonical* entry in What's New 3.15 gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS Aug 23, 2026
@advitrocks9

Copy link
Copy Markdown
Author

The NEWS entry doesn't name urlsafe_b64decode(), so it doesn't have the What's New problem. It says base16 got canonical, and it didn't. b16decode() and binascii.a2b_hex() are unchanged, GH-146312 never touched them. Removed base16 from the entry in this PR.

Separately, the binascii bullet in What's New only lists a2b_base64(), but a2b_base32(), a2b_ascii85() and a2b_base85() also got the parameter. Can add them here or in a separate PR.

@picnixz

picnixz commented Aug 23, 2026

Copy link
Copy Markdown
Member

Nah for What's New it's ok.

@picnixz
picnixz requested a review from gpshead August 23, 2026 22:02

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch on base16 being errantly listed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants