gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS - #156302
Open
advitrocks9 wants to merge 2 commits into
Open
gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS#156302advitrocks9 wants to merge 2 commits into
advitrocks9 wants to merge 2 commits into
Conversation
…in What's New 3.15
Documentation build overview
|
Member
|
Can you check if a NEWS entry needs to be amended as well? |
Author
|
The NEWS entry doesn't name Separately, the binascii bullet in What's New only lists |
Member
|
Nah for What's New it's ok. |
gpshead
approved these changes
Aug 24, 2026
gpshead
left a comment
Member
There was a problem hiding this comment.
good catch on base16 being errantly listed as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3.15 What's New lists
urlsafe_b64decode()as one of the decoders that got canonical, but it never got the parameter:It doesn't call
b64decode(), it callsbinascii.a2b_base64()directly with a fixed set of arguments, so wideningb64decode()in GH-146312 didn't affect it. This drops it from the bullet, per gpshead on the issue.I went through the other bullets in the base64 section and checked them against the signatures. This is the only one that's off.
The NEWS entry for the same change (now in
Misc/NEWS.d/3.15.0b1.rst) says the base16 decoders got canonical, but none did:b16decode()andbinascii.a2b_hex()are unchanged. Removed base16 from that entry too.Docs only, so
skip news. Needs a backport to 3.15.base64module #155193