Feat: Horizontal posters for search and recommendations. - #3144
Open
ByAyzen wants to merge 13 commits into
Open
Conversation
…detection, update ABI dump
I hope this is the solution :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since horizontal posters were only available on the main page, I wanted to bring this support to the search and recommendations sections as well. To not break multi search, I disabled it there and only applied it to extension search. I also used @prerelease tag to be sure it doesn't break the stable version.
Parameters for implementing to extensions:
I'm not completely sure about these two parameters because they can feel confusing; I can agree to change them. I could place them directly into search and new*****LoadResponse similar to how mainpage does it.
AI Usage
I used AI for implementing this idea. After that, I checked and cleaned up the issues.
Tests
I tested on both prerelease and debug versions. Tested for 2 days and didn't have any problems.
**Two comparison images below;
Search
Recommendation