Some playground improvements - #4213
Open
Earlopain wants to merge 2 commits into
Open
Conversation
* Add color to empty locations * Fix display of string type as `[Object Object]` * Include slice for location fields * Add `location: ` to node locations like in ruby inspect output
Earlopain
commented
Aug 26, 2026
| let text = `${start.line}:${start.col}-${end.line}:${end.col}`; | ||
|
|
||
| if (includeSlice) { | ||
| const slice = source.slice(loc.startOffset, loc.startOffset + loc.length); |
Collaborator
Author
There was a problem hiding this comment.
So, this is not correct. slice does by character but the offsets are in bytes and I don't know how you'd handle this in javascript. It's already the same problem with offsetToLineCol but here it would be a bit more noticable I think
Javascript strings are always utf16, TextEncoder converts it to utf-8 bytes. Doing it like this seems like a fine solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Object Object]location:to node locations like in ruby inspect outputBefore:
After: