POT serialization optimization (with 87% improvement) - #1789
Merged
Conversation
String#+ creates a new string and copies everything accumulated so far. Repeating that for tens of thousands of entries is quadratic. I replaced the repeated concatenation with one join and results of 400-file build have significantly improved: - Before: 104.29s - After: 13.21s - Improvement: 87.3% - Output size: identical - SHA-256: identical
Collaborator
|
🚀 Preview deployment available at: https://b5779b1d.rdoc-6cd.pages.dev (commit: 81fe6fb) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#+ creates a new string and copies everything accumulated so far. Repeating that for tens of thousands of entries is quadratic.
I replaced the repeated concatenation with one join.
Benchmark results for a 400-file build have significantly improved:
Output in both cases is identical
Benchmark
Created git repo with the benchmark at rdoc-pot-serialization-benchmark.