Introduce raise_on_unhandled_modal browser configuration - #324
Merged
Conversation
The problem --- When executing a system test suite that relies on `confirm`, `prompt`, or other browser-level modals, the default behavior to ignore modally presented dialogs can cause false negatives. For example, a change to the implementation might accidentally introduce a perpetually prompting confirmation modal. While the test suite outputs "Modal window … has been opened" warnings, the underlying test still passes. The proposal --- This commit proposes a new Cuprite-level `:raise_on_unhandled_modal` option to control whether an unhandled modal warns, or raises. When set to `true`, then false negative test would fail, rather than pass.
route
force-pushed
the
pr-320-raise-on-unhandled-modal
branch
2 times, most recently
from
August 25, 2026 05:51
e965401 to
935b189
Compare
Browser#initialize mutated the caller's options hash with delete instead of dig, so Driver#reset! (called between every Capybara example) always saw the option as absent and forced it back to false after the very first use — the option never actually took effect via normal driver configuration. Raising directly from the Page.javascriptDialogOpening handler also doesn't work: that callback runs on Ferrum's background CDP dispatcher thread, so the exception never reaches the caller and permanently kills that thread, wedging the browser for the rest of the suite (reproduced: it cascades into unrelated failures in later examples). The dialog is now always answered first, on Ferrum's own command (captured via alias before overriding it), and the error is deferred and re-raised from the main thread on its next command call via ensure, so it fires whether or not that command itself raised. Also raises a proper Capybara::Cuprite::UnhandledModalError instead of a bare RuntimeError, and adds a CHANGELOG entry.
route
force-pushed
the
pr-320-raise-on-unhandled-modal
branch
from
August 25, 2026 05:57
935b189 to
e6751bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
When executing a system test suite that relies on
confirm,prompt, or other browser-level modals, the default behavior to ignore modally presented dialogs can cause false negatives.For example, a change to the implementation might accidentally introduce a perpetually prompting confirmation modal. While the test suite outputs "Modal window … has been opened" warnings, the underlying test still passes.
The proposal
This commit proposes a new Cuprite-level
:raise_on_unhandled_modaloption to control whether an unhandled modal warns, or raises. When set totrue, then false negative test would fail, rather than pass.